Skip to content

Added changes for fixing tests for Chaos Service Packages #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 28, 2025
Merged

Added changes for fixing tests for Chaos Service Packages #1297

merged 9 commits into from
Oct 28, 2025

Conversation

@Jonsy13
Copy link
Contributor

@Jonsy13 Jonsy13 commented Sep 11, 2025 •
edited
Loading

Title: Fixing issues in Unit/Acceptance Tests for Chaos Module

Summary:
This PR adds changes to fix all the issues in Unit/Acceptance Tests for Chaos Module along with some fixes for bugs found while running/validating the tests fixes.

Related Issues:
Reference any related issues or tickets

Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.

  • Create the resource and execute terraform apply. (Verify the resource is created)
  • Execute terraform apply again without any changes. (Verify no changes should be done)
  • Update the resource and execute terraform apply. (Verify the resource updated successfully)
  • Remove the content from resource file and execute terraform apply. (Verify the resource has been deleted)
  • Add again the resource and execute the terraform apply. (Verify the resource is created)
  • Verify the import the resource file is working fine.
  • In case of remote entity, Verify for both default and non default branch.

Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:

  • Code changes are well-documented.
  • Tests have been added/updated.
  • Changes have been tested locally.
  • Documentation has been updated.
PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

@Jonsy13
Copy link
Contributor Author

Jonsy13 commented Sep 11, 2025

Coverage Metrics -

Screenshot 2025-09-11 at 11 33 48 AM

bot2-harness pushed a commit that referenced this pull request Oct 6, 2025
@akshat-goyal-harness
fix: [PL-65349]: Fixing central notification rule (#1297)
849f723 
* 0a06cf #sdkRelease

* fa7eb7 reviewComments

* bbdf60 #codeCleanup

* 3cd976 #bugFix

* 478c18 #prCheck

* cebf79 #codeCleanup

* ecb53d #codeCleanup

* 9ccae8 #doc

* d337ce Merge remote-tracking branch 'origin/PL-65349-akshat' into PL-65349-akshat

* 6b0ec8 #deprecation

* a5e530 uts

* 1344ed #mergeConflict

* cdcd16 #pipeline-notification-rule-onboarding

* cc8c0c #deprecation

* dbc3cc uts

* 60f876 bugFix

* c1657a #pipeline-notification-rule-onboarding
@ritek01 ritek01 marked this pull request as draft October 6, 2025 04:44
@Jonsy13 Jonsy13 changed the title Added changes for fixing tests for Chaos Service Packages [DO NOT MERGE] Added changes for fixing tests for Chaos Service Packages Oct 24, 2025
@Jonsy13 Jonsy13 marked this pull request as ready for review October 24, 2025 05:17
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Jonsy13
❌ git

git seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Added fixes
110b7b0 
Signed-off-by: git <[email protected]>
shovanmaity
shovanmaity approved these changes Oct 24, 2025
View reviewed changes
Copy link

@shovanmaity shovanmaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Added fixes
0d0c9c3 
Signed-off-by: git <[email protected]>
@Jonsy13
Copy link
Contributor Author

Jonsy13 commented Oct 28, 2025

@ritek01 Can you please review/approve/merge this PR!

@ritek01 ritek01 merged commit 678f09b into harness:main Oct 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ritek01 ritek01 ritek01 approved these changes

+3 more reviewers

@shovanmaity shovanmaity shovanmaity approved these changes

@sagarkrsd sagarkrsd sagarkrsd approved these changes

@Adarshkumar14 Adarshkumar14 Adarshkumar14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Jonsy13 @CLAassistant @shovanmaity @sagarkrsd @Adarshkumar14 @ritek01